[PR feedback] Simplify branching logic and typing#2
Merged
breehall merged 1 commit intobreehall:emotion/breakpointfrom Jul 19, 2022
Merged
[PR feedback] Simplify branching logic and typing#2breehall merged 1 commit intobreehall:emotion/breakpointfrom
breehall merged 1 commit intobreehall:emotion/breakpointfrom
Conversation
- Prefer types from theme instead of the breakpoints service (which likely needs to be refactored to use the theme) - simplify output to use array logic to output/concatenate a string - Remove undefined type - improve unit tests: - catch console warn conditions - don't snapshot invalid/uncommon size combos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer types from theme instead of the breakpoints service (which likely needs to be refactored to use the theme)
simplify output to use array logic to output/concatenate a string
Remove undefined type
improve unit tests: