Merged
Conversation
VDU 24 sets the graphics viewport. essentially it sets a clipping rectangle, and that should be all it does… this fixes a bug whereby setting the graphics viewport would also effectively change the graphics origin. this is contrary to how Acorn handles VDU 24. (additionally setting the origin using VDU 29 would make for a double-offset) all uses of `translateViewport` have been changed to use `translateCanvas` instead. this should make behaviour more understandable, and more predictable, and consistent with Acorn. besides fixing the observed VDU 24 issue, this PR changes the behaviour of two other commands so that they now both work strictly relative to the defined graphics origin, ignoring the defined graphics clipping rectangle/viewport. those changes apply to `VDU 23,0,&89,4,x;t;` which sets the mouse cursor position, and the “get pixel” command `VDU 23,0,&84,x;y;`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VDU 24 sets the graphics viewport. essentially it sets a clipping rectangle, and that should be all it does…
this fixes a bug whereby setting the graphics viewport would also effectively change the graphics origin. this is contrary to how Acorn handles VDU 24. (additionally setting the origin using VDU 29 would make for a double-offset)
all uses of
translateViewporthave been changed to usetranslateCanvasinstead. this should make behaviour more understandable, and more predictable, and consistent with Acorn.besides fixing the observed VDU 24 issue, this PR changes the behaviour of two other commands so that they now both work strictly relative to the defined graphics origin, ignoring the defined graphics clipping rectangle/viewport. those changes apply to
VDU 23,0,&89,4,x;t;which sets the mouse cursor position, and the “get pixel” commandVDU 23,0,&84,x;y;fixes #71