Update DB tests with initialization and teardown#97
Merged
idroz merged 1 commit intobravetools:masterfrom Jun 24, 2022
Merged
Conversation
… afterwards. This allows the tests to run without running into errors. Previously, the `OpenDB` function would create a DB if it did not already exist, but this was changed.
idroz
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the tests to run without running into errors. Previously, the
OpenDBfunction would create a DB if it did not already exist, but this was changed in 5953070 to avoid issues with empty db files being created.A test DB will be created prior to running tests and then deleted after the conclusion of all the tests.
The tests themselves could still use some more work to be more useful at testing the happy path, but at least with these issues the tests can run to completion without errors.