Skip to content

consider the case during brave base where package manager is not prov…#81

Merged
idroz merged 1 commit intomasterfrom
brave-base-bug-fix
Jun 9, 2022
Merged

consider the case during brave base where package manager is not prov…#81
idroz merged 1 commit intomasterfrom
brave-base-bug-fix

Conversation

@idroz
Copy link
Contributor

@idroz idroz commented Jun 9, 2022

…ided

@idroz idroz merged commit 4293722 into master Jun 9, 2022
@idroz idroz deleted the brave-base-bug-fix branch June 9, 2022 17:59
@Szubie
Copy link
Collaborator

Szubie commented Jun 10, 2022

Doesn't the "default" case added to the switch statement in 96c755a cover this case?

@idroz
Copy link
Contributor Author

idroz commented Jun 10, 2022

No, default throws an error because in this case package manager is "".

@Szubie
Copy link
Collaborator

Szubie commented Jun 10, 2022

I see - so if this part of the Bravefile is not specified the built cannot continue. That is a problem.

It does mean that if there are pacakges listed under a blank package manager that they will be skipped. But that's definitely a much smaller issue. Might add a check for that case specifically.

E.g.

packages:
  manager:
  system:
  - bash
  - wget
  - gnupg

@idroz
Copy link
Contributor Author

idroz commented Jun 10, 2022

In this case, if the manager is not specified, the section is skipped. If the user wants to install packages with a system manager before proceeding to the run section, they must specify explicitly apt/apk (other might be included in the fugure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants