Remove attempts to remove LXD image of same name when deleting a unit#74
Merged
beringresearch merged 1 commit intobravetools:masterfrom May 25, 2022
Merged
Conversation
…. However, in most cases, that image will not exist (cleaned up during build). Thus it would cause an error in most cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling the
removecommand without the-iflag, it is expected that the command would delete units instead of images. However, the command also attempts to remove any host LXD containers with the same name as the unit after deleting the unit.In most cases, that image will not exist - in theory temporary images should have been cleaned up during build. This leads to "Image alias not found" errors.
Even if there was an issue with leftover images needing to be cleaned up, this function would only help if the unit name and the image name matched, which isn't necessarily the case.