test dependencies before installation#33
Merged
adrozdovbering merged 3 commits intobravetools:masterfrom Nov 1, 2020
Merged
Conversation
Contributor
Author
|
sorry, there were some pretty dumb mistakes. but now it works :) |
Contributor
|
Thanks for that 👍 ! There are two places where dependencies could be/are checked in Bravetools - installation from source (your pull request could address that for Ubuntu/Debian) and installation from Bravetools binaries. Binary Installation
Installation from source
|
adrozdovbering
approved these changes
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, it would be really neat if you test your dependencies before installation :) any suggestions, what i could improve? i shellchecked the code but i am a huge fan of testing dependencies instead of writing them into the documentation :)