Merged
Conversation
…re compatability between old and new multipass instances by using -m flag to configure memory.
Collaborator
|
Made a few changes to ensure that the memory retrieval works on both Mac and Windows. The issue seems to have been that the awk command failed on Windows due to Powershell attempting to expand $2 into a variable. This made further processing of the string necessary on Windows. Also switched to configuring memory via shorthand "-m" to maintain compatibility with older Multipass versions. Tested on both Windows and Mac, so now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue seems to be caused by commands in line 610-611 of
platform/multipass.gobravetools/platform/multipass.go
Line 610 in 8efe68e
The commands do not return complex strings that required splitting on ":" and instead seem to return the desired integer values.
The change requires testing locally of the two commands in lines 610-611 of the
platform/multipass.gofile to ensure they do not return any special characters.Will merge when all tests confirm.