Skip to content

Resource panic#228

Merged
idroz merged 2 commits intobravetools:masterfrom
Szubie:resource-panic
Dec 3, 2022
Merged

Resource panic#228
idroz merged 2 commits intobravetools:masterfrom
Szubie:resource-panic

Conversation

@Szubie
Copy link
Collaborator

@Szubie Szubie commented Dec 2, 2022

Addresses #220

Changes:

  • No longer panic when empty RAM string is provided.
  • Skip network device config if no static IP requested

With this change it's possible to skip resource checks by providing an empty string "" to the values for RAM/CPU.

@Szubie Szubie linked an issue Dec 2, 2022 that may be closed by this pull request
@idroz idroz merged commit a0f1e88 into bravetools:master Dec 3, 2022
@Szubie Szubie deleted the resource-panic branch December 21, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to skip resource checks

2 participants