Name multipass VM "bravetools" instead of username#227
Merged
idroz merged 4 commits intobravetools:masterfrom Dec 5, 2022
Merged
Name multipass VM "bravetools" instead of username#227idroz merged 4 commits intobravetools:masterfrom
idroz merged 4 commits intobravetools:masterfrom
Conversation
storage pool name. Update docs with changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multipass VM will now be called "bravetools" to avoid potential collisions with existing VMs. In a multi-user scenario this bravetools VM will be shared between all users -
brave inithas been adjusted to check for existing VM.The LXD bridge will also be shared and will be called "bravetoolsbr0".
Storage pool name is now same as LXD profile name (which is username), no longer has the timestamp. This aids discoverabiltiy in future.
Username cleaning has been removed due to strict limitations of LXD bridge names no longer being applicable.
Docs updated with latest changes.