Skip to content

Accept path to composefile#223

Merged
idroz merged 1 commit intobravetools:masterfrom
Szubie:composefile-path-arg
Dec 1, 2022
Merged

Accept path to composefile#223
idroz merged 1 commit intobravetools:masterfrom
Szubie:composefile-path-arg

Conversation

@Szubie
Copy link
Collaborator

@Szubie Szubie commented Dec 1, 2022

Accepting path to composefile as well as path to dir in the CLI command brave compose - more intuitive for user.

Closes #142

@idroz
Copy link
Contributor

idroz commented Dec 1, 2022

Do we need to worry about a case where multiple compose files can be under one directory?

@Szubie
Copy link
Collaborator Author

Szubie commented Dec 1, 2022

Since only the brave-compose.yml file will be searched for when a dir is passed we cannot handle multiple composefiles existing in the same dir given only the directory - there is no way of determining a composefile apart from the name and there can only be one file with that name in a dir.

However, we could extend the CLI command to accept multiple args and handle multiple composefiles that way. In the simplest case this would just a loop over input files running compose on each of them in turn, but we could also handle it in other ways such as merging the files into one.

@idroz idroz merged commit 90818a0 into bravetools:master Dec 1, 2022
@Szubie Szubie deleted the composefile-path-arg branch December 1, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brave compose command - accept both a filepath and directory path

2 participants