Closed
Conversation
…ory - if cleanup succeeds, err will be set to nil, causing later panic
…. Prefix with brave_ to make bravetools-mounted devices discoverable later. Benefit of reduced collision probability and ability to find device name in future given the unit name and path.
… cleanup of shared mount of err on mulitpass
…h to generate device name
…nal logic of trimming leading/trailing slashes if present.
…s when mounting shared volume
…he function on LXD functionality
…s provided to `brave mount`
…arlier in process to prevent mismatch between expected device path and actual
…this avoids potential clashes between basenames and also allows mounting the same folder to multiple different mount points
…M when unmounting a volume from a unit
… from output - abstracting away that implementation detail from user, who should operate on paths directly
… mount path source and target names
…volumes onto units. Refactor creation and deletion of these volumes to use the LXD API client - faster, improved error handling and less verbose.
… using paths instead of devices now
Merged
Collaborator
Author
|
Closing in favour of #180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branching off from #180
This is an example showcasing how
brave mountmight work with subcommands. It may not be necessary at the moment, but if any further expansion happens it might become necessary to avoid excessive argument overloading. Perhaps it has better clarity in some cases?If we were to handle the strange command mentioned in #180, where a new volume is created and then mounted to several other containers perhaps we could add a further subcommand for that with varargs