Merged
Conversation
…seImageString` function is reused to extract metadata from provided image string (version and arch) - since public LXD image store uses same schema this works. Updates to use the new image naming schema, forgoing the version field.
…ed tests to fail if run on computer with LXD bridge on a different IP address range
… cause legacy imagename parsing downstream
…ned here will be used when building image - if not present the Image field from Service will be used instead.
…ge, use the Image defined in build section
…e from a Bravefile. Separating these steps clears the way for making the build and deploy sections of the Bravefile independent of each other.
…alues of args rather than take a pointer to avoid side-effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #138
This PR separates the build section of the Bravefile from the Service section. This means it's now possible to build an image from a Bravefile that doesn't have a Service section at all.
Major Changes:
brave baseno longer alters the name of the image being imported. It also applies same schema as above to extract metadata (<image_name>[/version][/arch]).Minor:
Changes were largely made in a backwards compatible way - existing Bravefiles will continue to work.
If no Image value is provided in the build section, the Image field in the Service section will be used instead. Likewise, if no Image value is found in Service section during deploy, the build section Image field will be used - this means the Image field only needs to be defined once in the Bravefile, avoiding pointless repetition.