Add new remotes backend to bravetools.#125
Merged
idroz merged 1 commit intobravetools:masterfrom Aug 12, 2022
Merged
Conversation
Remotes are stored in a new "remotes" folder in bravetools home dir. A remote is a human-editable json file and associates a remote with a name, address, and protocol. TLS auth for a remote is loaded if necessary. For now, the only remote is the default bravetools local remote created during init - if all works fine then next step is to expose the ability to select different remotes to users.
idroz
reviewed
Aug 12, 2022
| @@ -21,6 +21,12 @@ const PlatformConfig = BraveHome + "/config.yml" | |||
| // ImageStore .. | |||
| const ImageStore = BraveHome + "/images/" | |||
Contributor
There was a problem hiding this comment.
for these paths, can we have filepath.Join to make it more os-agnostic
Collaborator
Author
There was a problem hiding this comment.
Unfortunately filepath.Join does not work with constants.
However, Windows is pretty good about accepting forward slashes in paths nowadays - many paths bravetools currently creates are actually a mixture of forward and backwards slashes and they still work fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remotes are stored in a new "remotes" folder in bravetools home dir. A remote is a human-editable json file and associates a remote with a name, address, and protocol. TLS auth for a remote is loaded if necessary.
For now, the only remote is the default bravetools local remote created during init - if all works fine then next step is to expose the ability to select and create different remotes to users.
Multiple protocols are supported for backends, allowing for use of the Unix socket when running on Linux for less overhead. This also potentially allows for storing remote "simplestreams" image stores as remotes too.