Set BraveHost Backend in factory function#119
Merged
idroz merged 1 commit intobravetools:masterfrom Aug 4, 2022
Merged
Conversation
…st must always have a Backend (due to use for resource checks) so this makes sense to enforce. Update tests and commands to use new function. Also disallow passing a different backend to BraveHost.HostInfo for now - its name implies and fact that it is attached to BraveHost suggests that it should only return information about current host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host must always have a Backend due to use for resource checks so this makes sense to enforce in factory function to avoid creation of invalid BraveHosts. Conceptually this aligns with current Bravetools design - there's always a local Backend on the host used for building and deploying.
Update tests and commands to use new function.
BraveHost.HostInfo method now returns info about the bravehost backend - its name implies and fact that it is attached to BraveHost suggests that it should only return information about current host.