Fix race condition in image cleanup when import local image#118
Merged
idroz merged 1 commit intobravetools:masterfrom Aug 2, 2022
Merged
Fix race condition in image cleanup when import local image#118idroz merged 1 commit intobravetools:masterfrom
idroz merged 1 commit intobravetools:masterfrom
Conversation
…n to get image fingerprint before importing local images for build or deployment to allow for cleanup without race conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
brave deployorbrave buildagainst a local image, the image fingerprint would not be returned until after the image was fully imported (we had to wait for operation to complete). As a result, interruption to build/deploy at this stage would mean cleanup code failed to work as it didn't have the image fingerprint to delete.Instead we can get the sha256 hash from the local file on disk instead to get the image fingerprint before starting the import for local images. This allows for cleanup without race conditions.