Merged
Conversation
…nt number of slashes. Return error instead.
…for the user when it is not provided.
… only at start, rather than anywhere in string
7afc47f to
37e36e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment it is mandatory to specify the base image location in the bravefile. Ideally this would not be necessary - it should not matter where the image is stored. The user should simply declare which image they want and the tool should automatically retrieve it in the smartest way possible.
This PR allows bravetools to infer image location by itself if not provided. First it will check the local image store for the image, before searching the public LXD image repo. GitHub images are identified by the presence of the "github.com/" prefix, just like when using the
brave basecommand.The "location" field still exists as an optional field - when specified it takes precedence over the above image location resolution logic, so this change is backwards compatible with existing Bravefiles. This allows the user to override the retrieval logic if necessary, but otherwise they can avoid twiddling with the Bravefile fields to account for whether image has been stored locally.