Swallowed errors in bravefile run#114
Merged
idroz merged 1 commit intobravetools:masterfrom Jul 19, 2022
Merged
Conversation
…file run section. Prevents errors from earlier commands being overwritten and ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently errors from commands and their exit codes are only checked once at the end of
bravefileRunfunction after looping through all commands. However, this means that only errors encountered on the last command will be caught - any earlier errors are overwritten by the last command. This means an error in early stages of bravefileRun will be swallowed silently.Instead, we can check for errors on every iteration of loop runinng commands in bravefile run section and return early if we find any. This will prevent errors from earlier commands being overwritten and ignored.
To make this change, I needed to interpret non-zero exit codes as errors in
bravefileRunfunction itself to terminate the loop. This was done anyway in host_api.go so should cause any new issues.