Wait for LXD cert to become valid#108
Merged
idroz merged 1 commit intobravetools:masterfrom Jul 15, 2022
Merged
Conversation
…e sync issues between VM and host from causing the cert to be judged invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
brave initon Windows I have been consistently encountering the following error which interrupts the init:It appears that LXD recently changed their cert validation, which seems to have tightened restrictions as this didn't happen before.
The problem likely occurs due to time-sync issues between the host and VM, since the certificate is already valid according to the host but gets rejected by LXD running inside of multipass.
Addding a short 5-second sleep after retrieving remote LXD cert appears to help prevent time sync issues between VM and host from causing the cert to be judged invalid. It's a bit arbitrary but it allows me to run
brave init- will keep an eye on this in case we need to change the length of the sleep in future.