Skip to content
This repository was archived by the owner on Jan 4, 2019. It is now read-only.

Update incognito session initialization#648

Merged
darkdh merged 1 commit intoC69from
fix-15191
Sep 13, 2018
Merged

Update incognito session initialization#648
darkdh merged 1 commit intoC69from
fix-15191

Conversation

@bsclifton
Copy link
Copy Markdown
Member

@bsclifton bsclifton commented Sep 13, 2018 •
edited
Loading

With https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5, the values being registered in a session were changed from an exclusion (ex: which values to NOT put in OverlayUserPrefStore) to an inclusion (ex: which values to PERSIST, even in an incognito profile)

Fixes brave/browser-laptop#15191

@bsclifton
Update incognito session initialization
d57534a 
With https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5, the values were changed from an exclusion (ex: which values to NOT put in `OverlayUserPrefStore`) to an inclusion (ex: which values to PERSIST, even in an incognito profile)

Fixes brave/browser-laptop#15191
@bsclifton bsclifton self-assigned this Sep 13, 2018
@bsclifton
Copy link
Copy Markdown
Member Author

bsclifton commented Sep 13, 2018

I renamed the variables/methods to match the renaming done upstream:

AddOverlayPref => RegisterPersistentPref
overlay => persist
overlay_pref_names => persistent_pref_names_

See https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5%5E%21/#F4 for more info

bsclifton
bsclifton commented Sep 13, 2018
View reviewed changes
brave/browser/brave_browser_context.cc
if (IsOffTheRecord()) {
overlay_pref_names_.push_back("app_state");
overlay_pref_names_.push_back(extensions::pref_names::kPrefContentSettings);
overlay_pref_names_.push_back(prefs::kPartitionPerHostZoomLevels);
Copy link
Copy Markdown
Member Author

@bsclifton bsclifton Sep 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the actual important fix (above 3 lines); NOT passing these to what because an inclusion list for incognito pref key names

@darkdh darkdh merged commit a712524 into C69 Sep 13, 2018
@bsclifton bsclifton deleted the fix-15191 branch September 13, 2018 23:54
@bsclifton bsclifton mentioned this pull request Sep 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@diracdeltas diracdeltas Awaiting requested review from diracdeltas

1 more reviewer

@darkdh darkdh darkdh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsclifton bsclifton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bsclifton @darkdh