Skip to content

feat(wallet): Add support for solana NFt metadata#16308

Merged
muliswilliam merged 1 commit into
masterfrom
feat-solana-nft-metadata
Dec 9, 2022
Merged

feat(wallet): Add support for solana NFt metadata#16308
muliswilliam merged 1 commit into
masterfrom
feat-solana-nft-metadata

Conversation

@muliswilliam

Copy link
Copy Markdown
Contributor

Resolves brave/brave-browser#27129

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Solana.NFT.Metadata.mov

@muliswilliam muliswilliam requested a review from a team as a code owner December 9, 2022 11:47
@github-actions github-actions Bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 9, 2022

@onyb onyb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds

Copy link
Copy Markdown
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit a655440 into master Dec 9, 2022
@muliswilliam muliswilliam deleted the feat-solana-nft-metadata branch December 9, 2022 14:50
@github-actions github-actions Bot added this to the 1.48.x - Nightly milestone Dec 9, 2022
@nuo-xu

nuo-xu commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

hey @muliswilliam
wondering the token address you input when you are adding the NFT is the token address or the mint address?
im asking because the correct metadata only returned for mint address not token address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/storybook-url Deploy storybook and provide a unique URL for each build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced Solana NFT gallery support (frontend desktop changes)

4 participants