Autofill Expiration Date Double Slash Fix#89
Merged
sshropshire merged 7 commits intomasterfrom May 26, 2020
Merged
Conversation
scannillo
reviewed
May 20, 2020
CardForm/src/main/java/com/braintreepayments/cardform/view/RemoveSlashesFilter.java
Outdated
Show resolved
Hide resolved
scannillo
approved these changes
May 20, 2020
sestevens
reviewed
May 21, 2020
sestevens
reviewed
May 21, 2020
| int numChars = source.length(); | ||
| for (int index = 0; index < numChars; index++) { | ||
| char c = source.charAt(index); | ||
| if (source.charAt(index) != '/') { |
Contributor
There was a problem hiding this comment.
Would it make sense to filter out anything that isn't a number?
Contributor
Author
There was a problem hiding this comment.
Most def! I went with a digitsOnly filter that's a good call.
sestevens
approved these changes
May 21, 2020
Contributor
sestevens
left a comment
There was a problem hiding this comment.
Couple small suggestions, but overall looks good!
Co-authored-by: sestevens <51723734+sestevens@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autofill Expiration Date Double Slash Fix
Summary of changes
Checklist