Skip to content

File a Duplicate feature 💪#76

Closed
steipete wants to merge 5 commits intobr1sk:masterfrom
PSPDFKit-labs:peter/fileadupe
Closed

File a Duplicate feature 💪#76
steipete wants to merge 5 commits intobr1sk:masterfrom
PSPDFKit-labs:peter/fileadupe

Conversation

@steipete
Copy link
Copy Markdown

@steipete steipete commented Jun 21, 2017

This adds a new button that fetches radars from OpenRadar.

It's not pretty, but it works. Feel free to improve my Swift.

If you want to try it and enjoy executing binaries from random internet people, be my guest 🙃

PS: If you want to learn how to write great bug reports, check out the PSPDFKit blog.

dupe

Matching of Areas could be better (but they also have been updated and need fixing...)

This adds a new button that fetches radars from OpenRadar.
@keith
Copy link
Copy Markdown
Member

keith commented Jun 21, 2017

Haha, are you trying to have a feature-off with me 😛 #75

@keith
Copy link
Copy Markdown
Member

keith commented Jun 21, 2017

You can see on my PR that I actually chose to go down the other path and not parse the openradar summary response. I had an iteration that did that, but was worried it was too error prone, the only weird side effect is that even though it ends up looking the same on radarweb, when you fill the Brisk UI with it, since it only fills a single field, it feels pretty strange.

@steipete
Copy link
Copy Markdown
Author

@keith Ha, I wanted this for months, and now we build it within the same day? 🤷‍♂️

@keith
Copy link
Copy Markdown
Member

keith commented Jun 23, 2017

I've just merged #75 for the same feature here. Please try it out and let me know if you spot any issues. I ended up parsing the open radar response (at least in the common case). The big exception that I've noticed a few occurrences of on openradar is for radars that don't start with Summary: even though they follow the format otherwise. I might add a special case for that if it becomes on issue.

Sorry we ended up doing a bit of duplicate work here!

@steipete
Copy link
Copy Markdown
Author

Great work, thanks!

@steipete steipete closed this Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants