Remove whitespace from appleIDTextField#134
Merged
keith merged 2 commits intobr1sk:masterfrom Feb 10, 2018
Merged
Conversation
keith
reviewed
Feb 9, 2018
|
|
||
| @IBAction private func login(_ sender: Any) { | ||
| let username = self.appleIDTextField.stringValue | ||
| let username = self.appleIDTextField.stringValue.trimmingCharacters(in: .whitespacesAndNewlines) |
Member
There was a problem hiding this comment.
Ah nice, can you do this for the password field as well I guess
Contributor
There was a problem hiding this comment.
Doing this on the password field seems a bit too heavy-handed since anyone with a leading or trailing space in a password couldn't use the app anymore.
Contributor
Author
There was a problem hiding this comment.
Right. I don't know Apple's policy on password but I have seen other apps that accept leading trailing whitespace as a valid password. Leading and trailing whitespace for emails though is invalid.
Member
|
Please add an entry to the changelog! |
For removing Apple ID Login whitespace.
keith
approved these changes
Feb 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133
Turns out that when using my text expander app for the email it adds a space at the end which causes authentication to fail.