Skip to content

ci: run test/lint on every PR so required conclusion checks always report#679

Merged
DorianZheng merged 1 commit into
mainfrom
ci/merge-queue-fix-pr-paths
Jun 8, 2026
Merged

ci: run test/lint on every PR so required conclusion checks always report#679
DorianZheng merged 1 commit into
mainfrom
ci/merge-queue-fix-pr-paths

Conversation

@DorianZheng

@DorianZheng DorianZheng commented Jun 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Problem

After enabling the merge queue, Test (conclusion) and Lint (conclusion) were made required status checks. But test.yml / lint.yml still had a paths: filter on the pull_request trigger, so a PR not touching those paths never runs the workflow — and the required conclusion check stays Pending, blocking the PR from merging.

Observed live on #678 (changed only scripts/test/e2e/** + make/** → test.yml never ran → Test (conclusion) missing). Confirmed by GitHub docs: "a workflow skipped due to path filtering... checks... remain 'Pending'... blocked from merging."

Fix

Remove the paths: filter from the pull_request trigger on both workflows so they run on every PR (matches rust-analyzer/bevy, which have no top-level paths on their gating workflows). Nothing else changes:

  • Per-suite filtering still happens in the changes job (heavy jobs skip when unaffected).
  • The conclusion job reports success-or-skipped, so it always reports green for unrelated PRs.
  • push: paths are kept as-is (irrelevant to PR gating).

Cost: ~3 small jobs (config/changes/conclusion) per workflow per PR.

Note

PRs opened before #677 merged still lack the conclusion jobs entirely and need a rebase onto main to pick them up — separate from this fix.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflows to ensure status checks remain responsive on all pull requests targeting main, preventing them from getting stuck in a pending state.

@DorianZheng
ci: run test/lint on every PR so required conclusion checks always re…
76cb505 
…port

The pull_request trigger still had a paths filter, so a PR not touching those
paths never ran the workflow and its required Test/Lint (conclusion) check
stayed Pending → PR blocked from merging (observed on #678; confirmed by GitHub
docs on path-filtered required checks).

Remove the pull_request paths filter so both workflows run on every PR. Per-suite
filtering still happens in the changes job (heavy jobs skip when unaffected) and
the conclusion job reports success-or-skipped. push: paths are kept as-is.
@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ccae513b-01f2-436c-a28a-170fc684b565

📥 Commits

Reviewing files that changed from the base of the PR and between 5e08966 and 76cb505.

📒 Files selected for processing (2)
  • .github/workflows/lint.yml
  • .github/workflows/test.yml
📝 Walkthrough

Walkthrough

GitHub Actions workflow configurations in .github/workflows/lint.yml and .github/workflows/test.yml are updated to remove path-based filtering from the pull_request trigger. Both workflows now run on every PR targeting main, with explanatory comments noting that this prevents required status checks from being stuck in a pending state. Suite-level skipping is handled downstream by the existing changes job.

Changes

Workflow Trigger Configuration

Layer / File(s) Summary
Remove path filters from pull_request triggers
.github/workflows/lint.yml, .github/workflows/test.yml		 Both lint and test workflows remove path-based event filtering from the pull_request trigger. Comments explain that workflows must run on all PRs to prevent the required conclusion status checks from being stuck pending; suite-level skipping remains handled by the downstream changes job.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 When paths once guarded the gates with care,
Now every PR finds the workflow there!
No more pending checks in the air so blue,
The suites skip downstream—we know what to do! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing path filters from pull_request triggers to ensure required conclusion checks always report, which directly addresses the problem described in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/merge-queue-fix-pr-paths

Comment @coderabbitai help to get the list of available commands and usage tips.

@DorianZheng DorianZheng enabled auto-merge June 8, 2026 13:37
@DorianZheng DorianZheng disabled auto-merge June 8, 2026 13:37
@DorianZheng DorianZheng merged commit f6e934b into main Jun 8, 2026
32 checks passed
@DorianZheng DorianZheng deleted the ci/merge-queue-fix-pr-paths branch June 8, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DorianZheng