test: keep-going matrix via FAIL_FAST + FILTER for every suite#534
Merged
Conversation
Aggregator targets previously aborted at the first failing sub-suite, so one Rust failure skipped CLI and the entire SDK suite. Add a run_suites helper gated by FAIL_FAST (default false, mirroring GitHub Actions strategy.fail-fast) so the whole matrix runs and exits non-zero with a summary; FAIL_FAST=true restores fail-fast. Also wire FILTER into every test target (rust unit/integration, ffi, cli, python, node, c, go) mapped to each runner's native name selector, and fix test:integration:cli's broken raw nextest filterset. Both FAIL_FAST and FILTER are exported so they propagate through the recursive sub-makes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_suiteshelper gated byFAIL_FAST(defaultfalse, mirroring GitHub Actionsstrategy.fail-fast). Aggregator targets (test:all,test:unit*,test:integration*,test:changed*,test:all:{python,node,c}) now run every sub-suite even when an earlier one fails, then exit non-zero with a❌ Failed suites:summary.FAIL_FAST=truerestores abort-at-first-failure.FILTER=<pattern>into every leaf test target — previously onlytest:integration:rustandtest:integration:cli. Each runner getsFILTERmapped to its native name selector: nextest-E 'test(~…)', cargo…, pytest-k, vitest-t, ctest-R, go-run.test:integration:cli, which used-E 'test($(FILTER))'(raw nextest filterset —FILTER=copywould error); now uses the same substring form as the rest.FAIL_FASTandFILTERareexported so a single top-level invocation propagates through the recursive sub-makes.Motivation: a CI
make test:integrationrun aborted after Rust's failures and never ran CLI/Python/Node/C, hiding their status.Test plan
make -nfor all 11 leaf targets shows the correct native filter flag withFILTER=…, and the exact pre-change command with noFILTER(no-op safe).test:integration:cli FILTER=copynow emits-E 'test(~copy)'.FAIL_FAST=falseruns all suites +❌summary + exit 1;FAIL_FAST=truestops at first failure + exit 1.FILTER/FAIL_FASTreach leaf sub-makes via command-line and env.make test:integration FILTER=copyexecutes only the matching subset across suites.