fix(dashboard): constrain dialog grid/flex children so long values stay inside on mobile#518
Merged
Merged
Conversation
…ay inside on mobile PR #513 added CopyableValue (`min-w-0 flex-1 overflow-x-auto` on the value span) so long SSH commands and API keys would scroll inside the row instead of pushing siblings. The fix works in isolation but the row itself still escapes its dialog on narrow viewports — reproducer is the Sandboxes "Create SSH Access" dialog, where the ssh command renders past the right edge of AlertDialogContent. Root cause: `AlertDialogContent` uses `display: grid` with no explicit `grid-template-columns`, so it gets a single implicit auto column whose items default to `min-width: auto` (= min-content). With `whitespace-nowrap` on the CopyableValue value span, that min-content is the full unbreakable SSH command, so the grid item grows past `max-w-[calc(100%-2rem)]` and visually clips at the viewport. `DialogContent` has the same shape with `flex flex-col` items (which also default to `min-width: auto` on the cross axis). Fix: - AlertDialogContent: add `grid-cols-[minmax(0,1fr)]` so the single column is `minmax(0,1fr)` instead of implicit auto. Items can now shrink below content width, and CopyableValue's internal `overflow-x-auto` engages. - DialogContent: add `[&>*]:min-w-0` so every direct flex-col child gets `min-width: 0`. Same effect: children can shrink, content scrolls inside the row. Fixes every existing CopyableValue + future long-content cases in one place instead of patching every call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #513 added
CopyableValue(min-w-0 flex-1 overflow-x-autoon the value span) so long SSH commands / API keys would scroll inside the row instead of pushing siblings. The fix works in isolation but on narrow viewports the row itself still escapes its dialog — reproducer: Sandboxes → Create SSH Access on mobile, thessh -p 2222 …command renders past the right edge ofAlertDialogContent.Root cause
AlertDialogContentisdisplay: gridwith no explicitgrid-template-columns, so it gets a single implicit auto column whose items default tomin-width: auto(= min-content). Withwhitespace-nowrapon the value span, that min-content is the full unbreakable SSH command — the grid item grows pastmax-w-[calc(100%-2rem)]and clips at the viewport.DialogContenthas the same latent shape withflex flex-colitems.Fix
AlertDialogContent: addgrid-cols-[minmax(0,1fr)]so the implicit auto column becomesminmax(0,1fr). Children can now shrink below content-width, and CopyableValue's internaloverflow-x-autoengages.DialogContent: add[&>*]:min-w-0so every direct flex-col child getsmin-width: 0(Tailwind arbitrary child-selector).One-line each. Fixes every CopyableValue site + any future long-content dialog without patching call sites.
Test plan
sm:max-w-lg/sm:max-w-2xlwidths).