ci(e2e): expand subnet pool to all AZs in the VPC#500
Merged
Conversation
The workflow's multi-AZ fallback (#491) iterates over `AWS_SUBNET_IDS`, but the setup script only saved one subnet (`AWS_SUBNET_ID`), so the fallback degenerated to a single-AZ try. Run today hit InsufficientInstanceCapacity for c8i.4xlarge in us-east-1f and gave up even though five other AZs were available. Enumerate every public subnet in the VPC, comma-join, and write `AWS_SUBNET_IDS`. Delete the legacy `AWS_SUBNET_ID` variable so the workflow's `vars.AWS_SUBNET_IDS || vars.AWS_SUBNET_ID` fallback can't silently revert to a narrower pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e-test.yml(ci(e2e): add multi-AZ fallback for EC2 instance creation #491) iterates overAWS_SUBNET_IDS, but the setup script only ever wroteAWS_SUBNET_ID(singular). The iteration degenerated to a single AZ, so today's run died onInsufficientInstanceCapacityforc8i.4xlargeinus-east-1feven though five other AZs had spare capacity.AWS_SUBNET_IDS, and deletes the legacyAWS_SUBNET_IDso the workflow'svars.AWS_SUBNET_IDS || vars.AWS_SUBNET_IDfallback can't quietly revert to a one-AZ pool.Test plan
./scripts/ci/setup-ci-runner.sh. Verify it printsPublic subnets... ✓ subnet-...,subnet-... (N AZs)and savesAWS_SUBNET_IDS.gh variable list -R boxlite-ai/boxliteshowsAWS_SUBNET_IDS(plural) populated andAWS_SUBNET_ID(singular) absent.Start E2E Runnerlog should iterate subnets and land on one with capacity instead of failing on the first AZ.