ci(e2e): switch to persistent stop/start model#487
Merged
Conversation
bcfafa6 to
bba7597
Compare
Replace ephemeral create/terminate with persistent stop/start: - Instance created once, never terminated (build cache persists) - Workflow starts stopped instance, runs tests, stops it after - Single global concurrency group prevents conflicts - ~$0.03/run (cached) vs ~$0.09/run (cold build every time) - EBS cost: ~$4/mo for 50GB volume Concurrency safety: `group: e2e-runner` ensures only one job runs at a time. Newer pushes cancel in-progress runs. Requires: EC2_E2E_INSTANCE_ID variable (set by setup script)
bba7597 to
899b4ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace ephemeral create/terminate with persistent stop/start for cost efficiency.
Changes
e2e-runner) prevents two jobs using the instance simultaneouslyCost improvement
Concurrency safety
concurrency.group: e2e-runner— single global lockcancel-in-progress: true— newer push cancels older runif: always()even on cancellationSetup required
A persistent EC2 instance with the runner pre-installed (setup script TBD).
Need to add
EC2_E2E_INSTANCE_IDvariable.Test plan
EC2_E2E_INSTANCE_IDvariable