chore(setup): install Node 22 LTS via unified setup_nodejs#466
Merged
Conversation
Distro Node on Ubuntu 24.04 ships v18 (EOL 2025-04-30) and the manylinux path was pinned to v20.18 (EOL 2026-04-30), so make setup produced a Node that's too old for the SDK's transitive devDeps (@napi-rs/cli@3 -> @inquirer/core@11 needs >=20.12). Mirror the existing setup_go pattern: a shared check_nodejs that validates the version, three platform installers (Homebrew node@22, NodeSource setup_22.x, nodejs.org tarball), and a setup_nodejs orchestrator. Per-env scripts now delegate to setup_nodejs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Node SDK's `@napi-rs/cli@3` transitively requires `@inquirer/core@11` (engines `>=20.12`). On Ubuntu 24.04, `apt-get install nodejs` lands Node 18 (EOL since 2025-04-30), so `make test` fails at the `napi build` step. The manylinux path was hardcoded to Node 20.18, which hit EOL on 2026-04-30.
What's installed where
`SKIP_INSTALL_NODEJS=1` still works as an opt-out.
Known gaps (deferred)
Test plan