[codex] Auto-use sudo in Linux setup scripts#444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the Linux setup scripts to auto-use
sudowhen the current shell is not already running as root.What Changed
setup_sudo,require_root_or_sudo, andrun_with_sudohelpers inscripts/setup/setup-common.sh/usr/localwrites through the shared sudo helperWhy
make setupon manylinux failed immediately for non-root users because the manylinux setup script invokedyum,pip3,unzip, andtardirectly, unlike the Ubuntu setup flow which already auto-usedsudo. This makes the Linux setup behavior consistent across supported distributions.User Impact
Non-root users can run
make setupon manylinux and musllinux the same way they do on Ubuntu, withsudoapplied automatically when system package installation or writes to/usr/localare required.Validation
bash -n scripts/setup/setup-common.shbash -n scripts/setup/setup-manylinux.shbash -n scripts/setup/setup-musllinux.shbash -n scripts/setup/setup-ubuntu.shgit diff --check