Expose runtime image handles across SDKs safely#433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
libboxlite.aandinclude/boxlite.hinto the module cacherestdependency test-only, document the current Gocontext.Contextcancellation limitation, and cache image handles in Node/Python instead of re-fetching them per callWhy
The SDKs needed parity with the core runtime image APIs, but the initial rollout had two real follow-up issues:
boxlite.hThis update keeps the SDK image-handle API, fixes the Go module packaging path, and makes the shutdown contract explicit across the FFI and language bindings.
Impact
runtime.images.pull(...)andruntime.images.list()consistently across Python, Node, Go, and Cgo get github.com/boxlite-ai/boxlite/sdks/gocan build from the published module cache againruntime.images()setup cost on every callRoot cause
sdks/goValidation
cargo fmt --allgit diff --checkcargo test -p boxlite-fficargo clippy -p boxlite-ffi --tests -- -D warningscargo check -p boxlite-node -p boxlite-pythoncd sdks/go && go test ./cmd/setupmake testhook for changed components (c ffi go node python rust)