refactor(go): replace go generate with setup tool and flatten CGO structure#386
Merged
Conversation
…ucture Replace the go generate workflow with a standalone setup tool that downloads libboxlite.a from GitHub Releases into the Go module cache. Flatten all platform CGO directives into a single bridge_cgo_prebuilt.go using #cgo darwin/#cgo linux prefixes, eliminating the lib/ subdirectories and per-platform wiring files. User workflow is now: go get github.com/boxlite-ai/boxlite/sdks/go go run github.com/boxlite-ai/boxlite/sdks/go/cmd/setup go build ./...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go generateworkflow with a standalonecmd/setuptool that downloadslibboxlite.afrom GitHub Releases into the Go module cachebridge_cgo_prebuilt.gousing#cgo darwin/#cgo linuxprefixeslib/subdirectories, per-platform wiring files, andinternal/download/— no submodules needed since.afiles are downloaded, not committedUser workflow is now:
Test plan
go build ./...passes withlibboxlite.apresentgo test -v ./...passes (15/15 tests)CGO_ENABLED=0 go build ./cmd/setup/builds setup tool as pure Godarwin-arm64) and version.gitignoreexcludessdks/go/libboxlite.a