Put file sorting behind a CLI flag#1553
Merged
theofidry merged 2 commits intobox-project:mainfrom Oct 31, 2025
Merged
Conversation
Contributor
Author
|
Looks like the failing CI pipeline is due to an upstream change in assertion error messages related to files: webmozarts/assert#291 See removal of the |
theofidry
reviewed
Oct 27, 2025
Member
theofidry
left a comment
There was a problem hiding this comment.
Thanks a lot @timacdonald; apologies I got distracted and kinda forgot about it last week.
The CI should now be green. Could you also add a mention in the docs too? The file to update is doc/reproducible-builds.md.
c55877f to
b8cdc8c
Compare
b8cdc8c to
20fe7d4
Compare
Contributor
Author
|
I've added the documentation |
Member
|
Thank you very much @timacdonald! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1534, we added the ability to force file sorting. This creates more consistent builds both within the same system and across different systems.
Unfortunately, it seems this feature had a big impact on PHPStan's compile time and is likely impacting other builds we have not yet had reports on.
This PR restores the CLI option to enable file sorting.
Hopefully in the future we can dig deeper into why this happened with PHPStan and address the slowdown directly in order to make this the default, but for now this should get us out of trouble.
fixes #1551