fix: Fix the autoloading of the excluded files#1323
Merged
theofidry merged 4 commits intobox-project:mainfrom Apr 7, 2024
Merged
fix: Fix the autoloading of the excluded files#1323theofidry merged 4 commits intobox-project:mainfrom
theofidry merged 4 commits intobox-project:mainfrom
Conversation
This fixes the integration of humbug/php-scoper#864 within Box which was done in box-project#1142.
Member
Author
|
Waiting for feedback on phpstan/phpstan-src#2905 |
Member
Author
|
From my testing this looks to be fixing the issues. There is more issues related to the polyfill but that's a separate PHP-Scoper issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the integration of
humbug/php-scoper#864 within Box which was done in #1142.
The issue was that the relative file paths was passed instead of hashes. Note that we create the file hasher in a different way than in PHP-Scoper, since PHP-Scoper has to deal with the vendor directory from the source and the scoped one, and deals with absolute paths. In Box however, this is not the case, we directly get relative file paths (relative to the working directory)