osconfig: install root ssh keys to /var/roothome#407
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Mar 21, 2024
Merged
osconfig: install root ssh keys to /var/roothome#407cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
3171be6 to
6b24170
Compare
cgwalters
reviewed
Mar 20, 2024
6b24170 to
bd69633
Compare
mvo5
commented
Mar 21, 2024
Contributor
Author
mvo5
left a comment
There was a problem hiding this comment.
Thank you! This looks great and works well in my test. There is a tiny tweak in the tests needed it seems though.
bd69633 to
247cbdc
Compare
The current location via tmpfiles.d to install the root ssh keys seems to be not working. There is an error that `/root/.ssh` does not exist from `systemd-tmpfiles-setup` and indeed the authorized_keys file is on in `/root/.ssh`. It seems like everything else in the firstboot in tmpfiles.d is refering to `/var/roothome` instead of `/root` and switching to this for the location of the ssh keys solves the issue. Co-authored-by: Colin Walters <walters@verbum.org> Signed-off-by: Colin Walters <walters@verbum.org>
247cbdc to
119dbb4
Compare
mvo5
commented
Mar 21, 2024
Contributor
Author
mvo5
left a comment
There was a problem hiding this comment.
Thank you so much! 👍 for all the change that I did not make (which are all relevant ones ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current location via tmpfiles.d to install the root ssh keys seems to be not working on firstboot. There is an error that
/root/.sshdoes not exist fromsystemd-tmpfiles-setupand indeed the authorized_keys file is on in/root/.ssh.It seems like everything else in the firstboot in
tmpfiles.d is refering to
/var/roothomeinstead of/rootand switching to this for the location of the ssh keys solves the issue.I tested this via bib and a local container using the new
bootc install to-filesystempipeline :) So hopefully it should finally work.