bootc-lib: fix ARM architecture support#1971
Merged
Johan-Liebert1 merged 1 commit intobootc-dev:mainfrom Feb 3, 2026
Merged
Conversation
Currently build fails for armv7, this fixes the issue:
```
1094.0 Compiling bootc-lib v1.12.1 (/bootc/crates/lib)
1097.2 error: Unsupported architecture
1097.2 --> crates/lib/src/discoverable_partition_specification.rs:523:13
1097.2 |
1097.2 523 | compile_error!("Unsupported architecture")
1097.2 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1097.2
1157.8 error: could not compile `bootc-lib` (lib) due to 1 previous error
1157.8 error: Generating manpages: Syncing man pages: Extracting CLI: Running CLI JSON dump command: command exited with non-zero code `cargo run --features=docgen -- internals dump-cli-json`: 101
1157.8 make: *** [Makefile:44: manpages] Error 1
1157.8 make: Leaving directory '/bootc'
```
Signed-off-by: Matija Tudan <tudan.matija@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a build failure on the ARMv7 architecture by adding support for target_arch = "arm" in the this_arch_root function. The change correctly uses conditional compilation to return the appropriate root partition GUID for 32-bit ARM systems. The implementation is straightforward and effectively resolves the issue described.
Johan-Liebert1
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently build fails for armv7, this fixes the issue: