cli: Hide config-diff and delete-deployment#1758
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Nov 13, 2025
Merged
Conversation
These were added without docs or tests and only apply right now to the composefs backend. Hide them until they meet the above quality bars. Signed-off-by: Colin Walters <walters@verbum.org>
f2a9dd3 to
ff6f5cd
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly hides the config-diff and delete-deployment CLI commands by adding the #[clap(hide = true)] attribute. The change is simple, effective, and aligns with the goal of hiding these features until they are fully documented and tested. I have one minor suggestion to improve code consistency and readability.
| /// Diff current /etc configuration versus default | ||
| #[clap(hide = true)] | ||
| ConfigDiff, | ||
| #[clap(hide = true)] |
Contributor
There was a problem hiding this comment.
For consistency with the ConfigDiff variant and for better code readability, consider adding a doc comment explaining what this command does, even though it's hidden from the CLI.
/// Delete a deployment by ID
#[clap(hide = true)]
jeckersb
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were added without docs or tests and
only apply right now to the composefs backend. Hide them until they meet the above quality bars.