Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the CI and local build process to use bcvk for creating disk images, which simplifies the process and allows for unprivileged builds. The changes in the Justfile are a great simplification. In the GitHub Action workflow, I've noticed that the script to install bcvk is hardcoded for the x86_64 architecture, which would cause issues for multi-arch builds. I've provided a suggestion to make the installation script architecture-agnostic and more robust.
I think this is https://gitlab.com/virtio-fs/virtiofsd/-/issues/210 - investigating. |
|
OK yep bootc-dev/bcvk#60 will fix this |
8064346 to
455d1c7
Compare
Make builds unprivileged by default and start using bcvk in our own CI, the same way we expect people to do so locally now. Signed-off-by: Colin Walters <walters@verbum.org>
|
@henrywang can you review? |
Make builds unprivileged by default and start using bcvk in our own CI, the same way we expect people to do so locally now.