ci: Also validate the composefs-backend feature#1606
ci: Also validate the composefs-backend feature#1606cgwalters merged 1 commit intobootc-dev:composefs-backendfrom
Conversation
I was hitting a compliation error which *looks* like it was actaully an incremental compilation bug? Or it might have been rust-analyzer and local builds fighting over enabled features. Anyways, this ensures that we're gating on the composefs backend compiling. Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Code Review
This pull request correctly adds CI validation for the composefs-backend feature, which is a great step to ensure build stability. The associated changes in the Rust code to conditionally compile constants are appropriate and well-executed. I have one minor suggestion for the Makefile to improve the clarity of the build commands.
| (cd crates/ostree-ext && cargo check --no-default-features) | ||
| (cd crates/lib && cargo check --no-default-features) |
There was a problem hiding this comment.
For better maintainability and to avoid subshells, you can use cargo's -p flag to specify the package to check directly from the workspace root.
cargo check -p ostree-ext --no-default-features
cargo check -p bootc-lib --no-default-features
| } | ||
|
|
||
| /// Wrapper around [`rustix::openat`] | ||
| /// Wrapper around [`rustix::fs::openat`] |
There was a problem hiding this comment.
accidentally included this?
There was a problem hiding this comment.
Nope it's intentional, make validate-rust trips on it. See https://docs.rs/rustix/latest/rustix/fs/fn.openat.html
|
Hm is something wrong with the repo config? I have the "Merge pull request" button but there's not an approval on this yet. I won't touch it for the moment just incase we need this state to troubleshoot... |
|
branch protection doesn't apply to anything other than main right now |
I was hitting a compliation error which looks
like it was actaully an incremental compilation bug? Or it might have been rust-analyzer and local builds fighting over enabled features.
Anyways, this ensures that we're gating on the composefs backend compiling.