Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for a version skew issue with ostree and ostree-libs in the CI environment by adding a dnf distro-sync command. The change is straightforward and seems correct. My feedback includes a couple of suggestions to improve the maintainability and robustness of this change: one is to add a reference to the corresponding issue directly in a code comment, and the other is to avoid using bash-specific brace expansion for better portability.
This is a hackaround for https://gitlab.com/redhat/centos-stream/containers/bootc/-/issues/1174 Signed-off-by: Colin Walters <walters@verbum.org>
590e466 to
e7a3835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hackaround for https://gitlab.com/redhat/centos-stream/containers/bootc/-/issues/1174