Dockerfile: Support pulling in the continuous repo#1446
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Jul 24, 2025
Merged
Dockerfile: Support pulling in the continuous repo#1446cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism in the Dockerfile to optionally enable a continuous integration repository for fetching the latest ostree and bootupd packages. The changes are well-structured, using a new multi-stage build to conditionally apply these updates. My review includes suggestions to improve the robustness and debuggability of the shell script used for this purpose.
ckyrouac
approved these changes
Jul 24, 2025
6d8c1fb to
525d795
Compare
If enabled this pulls in git main of ostree which I want for soft reboot work. Signed-off-by: Colin Walters <walters@verbum.org>
525d795 to
8557d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If enabled this pulls in git main of ostree which I want for soft reboot work.