Skip to content

fix: IP-literal can be IPv6addrz#771

Merged
alandefreitas merged 1 commit intoboostorg:developfrom
alandefreitas:issue_711
Jul 20, 2023
Merged

fix: IP-literal can be IPv6addrz#771
alandefreitas merged 1 commit intoboostorg:developfrom
alandefreitas:issue_711

Conversation

@alandefreitas
Copy link
Copy Markdown
Member

This commit changes the IP-literal rule to also accept IPv6addrz as a valid ipv6 host type. IPv6addrz includes a ZoneID at the end, delimited by an encoded "%25". The ipv6_address class is unmodified, as the mapping from the ZoneID to a std::uint32_t is dependent on the application context. The original ZoneID can be obtained from the url_view.

fix #711

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 19, 2023

Codecov Report

Merging #771 (c01b82c) into develop (cac7c20) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #771      +/-   ##
===========================================
+ Coverage    97.26%   97.27%   +0.01%     
===========================================
  Files          155      156       +1     
  Lines         8518     8565      +47     
===========================================
+ Hits          8285     8332      +47     
  Misses         233      233              
Impacted Files Coverage Δ
include/boost/url/url_view_base.hpp 100.00% <100.00%> (ø)
src/rfc/detail/ip_literal_rule.cpp 91.89% <100.00%> (+3.00%) ⬆️
src/rfc/detail/ipv6_addrz_rule.cpp 100.00% <100.00%> (ø)
src/url_view_base.cpp 96.93% <100.00%> (+0.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac7c20...c01b82c. Read the comment docs.

@cppalliance-bot
Copy link
Copy Markdown

@cppalliance-bot
Copy link
Copy Markdown

This commit changes the IP-literal rule to also accept IPv6addrz as a valid ipv6 host type. IPv6addrz includes a ZoneID at the end, delimited by an encoded "%25". The ipv6_address class is unmodified, as the mapping from the ZoneID to a std::uint32_t is dependent on the application context. The original ZoneID can be obtained from the url_view.

fix boostorg#711
@cppalliance-bot
Copy link
Copy Markdown

@alandefreitas alandefreitas merged commit f2bb191 into boostorg:develop Jul 20, 2023
@alandefreitas alandefreitas deleted the issue_711 branch February 21, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost::urls::ipv6_address does not support scope id

2 participants