BK-2319 Registering multiple usernames with the same email address is possible#881
Merged
eos87 merged 4 commits intobooktype:masterfrom May 9, 2018
Merged
BK-2319 Registering multiple usernames with the same email address is possible#881eos87 merged 4 commits intobooktype:masterfrom
eos87 merged 4 commits intobooktype:masterfrom
Conversation
eos87
requested changes
May 7, 2018
Contributor
eos87
left a comment
There was a problem hiding this comment.
Please add the translation messages (makemessages) and push before merging this
Contributor
|
I agree about reworking the registration part, we should extend default django registration which works pretty well. |
Member
Author
|
Hi @eos87 , I've pushed messages, but this files were also edited by localiser, so it produces giant conflict. It is not a big deal to make new messages in a separate commit and push it later. Please, merge it. 🍺 |
Contributor
|
I can help merge the messages file. |
Contributor
|
Hi @ride90 I have made a pull request into your branch BK-2319 with the messages: https://github.com/ride90/Booktype/pull/1/files |
BK-2319 Resync translation messages
Member
Author
|
Thanks @danielhjames . @eos87 now you can hit merge button. |
eos87
approved these changes
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's temporary solution.
We definitely must rewrite entire register part, right now the logic is weird 👎