BK-2260 Paper sizes should be an instance or theme setting, and margins optionally hidden#845
Merged
eos87 merged 1 commit intobooktype:masterfrom Feb 27, 2018
Merged
Conversation
…ns optionally hidden
Contributor
|
Does anyone know why the paper size constants are defined in two places? lib/booktype/constants.py and lib/booktype/convert/pdf/constants.py both define PAGE_SIZE_DATA Is the latter file legacy code from the BookJS days? lib/booktype/constants.py also seems to have some data from Objavi, which is really ancient. |
Member
Author
|
Hi @danielhjames , yes, it is ancient parts 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @eos87 ,we discussed this issue with @danielhjames and we decided to hide a custom page size and remove hardcoded page sizes from the templates. Now page sizes come from the PAGE_SIZE_DATA constant. This constant is overridable in setting file.
In the future we will move page sizes settings inside theme info file, so each theme will have their own settings.
P.S. The same template changes were implemented for pdfreactor converter.