BK-2435 ContentCleanUpPlugin sometimes removes valid content#842
Merged
eos87 merged 1 commit intobooktype:masterfrom Jan 30, 2018
Merged
BK-2435 ContentCleanUpPlugin sometimes removes valid content#842eos87 merged 1 commit intobooktype:masterfrom
eos87 merged 1 commit intobooktype:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @eos87 ,
This pr is about how sweet lxml is :)
I would expect lxml walk through objects inside body (I hope you also expected it), but it does not. It walks starting from the root (html element), which is wrong for us. Check a screenshot from my debugger:

Here you can see what result gives
body.xpath("//*")in our context.Here we see another lxml's feature. When we execute this command, lxml removes element, let's say an empty

<a>and a content after it which belongs to parent. See a screenshot.In this context elem is a reference to an empty
<a>tag which is inside<p>, lxml removes an empty tag and rest of the content after it in context of parent's<p>.Please, test this pr with cases ContentCleanUpPlugin was developed for 🍺 🍺 🍺