BK-2367 Add ability to select layouts for images#798
Merged
ride90 merged 3 commits intobooktype:masterfrom Nov 22, 2017
Merged
Conversation
Contributor
|
Hi @ride90, it looks pretty good, although I found small issue.
To reproduce:
I saw another which was a modal warning saying about full page image, but I was unable to reproduce it, after seeing that modal I was not able to do any other change. I'll keep trying and If I find something I'll let you know. Other than that, it looks really good! great work my friend :) |
Member
Author
|
HI @eos87 , yes, I was able to reproduce this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @eos87 ,
Finally this fat PR is here.
It still has some issues, I guess user will not experience them in 99 percents of cases :)
I hide images from "contentrevision" for now, because we are not displaying images in diff correctly.
Image layouts feature for now supported only by epub 2/3 and xhtml outputs.
It also supports pdfreactor output, you can find update for css in pdfreactor repo (only one theme), other themes will be updated by @MiczFlor with generator.