Skip to content

fix: update to protobom/storage@v0.1.3 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhoward-lm merged 2 commits into from
Jun 27, 2024
Merged

fix: update to protobom/storage@v0.1.3 #86

jhoward-lm merged 2 commits into from
Jun 27, 2024

Conversation

@jhoward-lm
Copy link
Contributor

@jhoward-lm jhoward-lm commented Jun 27, 2024 •
edited
Loading

Update to use protobom storage backend fixes

Description

This PR updates the protobom/storage dependency to v0.1.3 to address the following issues:

  • document type enum value fix
  • use transactional client for storing so changes are rolled back when error occurs

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm
fix: update to protobom/storage@v0.1.3
514b2ec 
Solves the following issues:

- document type enum value fix
- use transactional client for storing so changes are rolled back when error occurs

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm added the bug Something isn't working label Jun 27, 2024
@jhoward-lm jhoward-lm self-assigned this Jun 27, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner June 27, 2024 14:40
@jhoward-lm
ci: update golangci-lint version in action
c5fb802 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
mfrystacky
mfrystacky approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mfrystacky mfrystacky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jhoward-lm jhoward-lm merged commit 4e558e5 into main Jun 27, 2024
@jhoward-lm jhoward-lm deleted the ent-storage-backend-fixes branch June 27, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashearin ashearin ashearin approved these changes

@mfrystacky mfrystacky mfrystacky approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@houdini91 houdini91 Awaiting requested review from houdini91

@idunbarh idunbarh Awaiting requested review from idunbarh

Assignees

@jhoward-lm jhoward-lm

Labels

bug Something isn't working

Projects

bomctl
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhoward-lm @ashearin @mfrystacky