Skip to content

feat: list command #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhoward-lm merged 6 commits into from
Jun 25, 2024
Merged

feat: list command #82

jhoward-lm merged 6 commits into from
Jun 25, 2024

Conversation

@jhoward-lm
Copy link
Contributor

@jhoward-lm jhoward-lm commented Jun 23, 2024 •
edited
Loading

List Command

Description

Add initial list sub command to display tabular info about documents currently stored in local database.

Miscellaneous

Change --verbose flag to indicate multiple levels of verbosity rather than true or false. For example, it can now be used as --verbose, --verbose=2, -v, -vv, etc.

  • --verbose/-v: logger messages at debug level are displayed
  • --verbose=2/-vv: in addition to above, all SQL statements executed by driver are printed by the ent backend client

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm jhoward-lm added the enhancement New feature or request label Jun 23, 2024
@jhoward-lm jhoward-lm self-assigned this Jun 23, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner June 23, 2024 19:48
@jhoward-lm
refactor: update to use new utility methods in ent storage backend
c4dcef2 
refactor:
- change --verbose flag to count instead of bool

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
fix: remove viper config bindings that don't make sense
f2037f4 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm linked an issue Jun 24, 2024 that may be closed by this pull request
LIST command #45
Closed
@jhoward-lm
chore: remove duplicate line
158a42a 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
chore: move constant to root command file
585c1fc 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
fix: ensure database client closed, verbosity config for fetch
f3b0921 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm merged commit a53d193 into main Jun 25, 2024
@jhoward-lm jhoward-lm deleted the list-command branch June 25, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashearin ashearin ashearin approved these changes

@idunbarh idunbarh idunbarh approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@jhoward-lm jhoward-lm

Labels

enhancement New feature or request

Projects

bomctl
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LIST command

4 participants

@jhoward-lm @ashearin @idunbarh