Skip to content

Conversation

@jhoward-lm
Copy link
Contributor

Remove globals, use functional options pattern

Description

  • Enable gochecknoglobals config for golangci-lint
  • Remove global variables
  • Pass options as structs instead of as parameters directly with functional option pattern support

Type of change

  • Refactor

How Has This Been Tested?

  • Local testing
  • Workflow

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm added the enhancement New feature or request label Jun 11, 2024
@jhoward-lm jhoward-lm self-assigned this Jun 11, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner June 11, 2024 18:18
@idunbarh idunbarh merged commit 72b7a56 into main Jun 11, 2024
@idunbarh idunbarh deleted the functional-options branch June 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants