Skip to content

feat: add gitlab push to generic package registry #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashearin merged 18 commits into from
Jan 27, 2025
Merged

feat: add gitlab push to generic package registry #266

ashearin merged 18 commits into from
Jan 27, 2025

Conversation

@lmphil
Copy link
Contributor

@lmphil lmphil commented Jan 13, 2025 •
edited
Loading

Description

Adds GitLab Push functionality to push an SBOM to a project's generic package repository.

Fixes issue #256

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested locally.
  • Tested using unit tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

lmphil added 5 commits January 8, 2025 17:45
@lmphil
feat: gitlab push
c66ffaf 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
fix gitlab push
f738a4b 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
gitlab push unit test draft
724e8ec 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
complete gitlab push unit test
aa112c0 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
Merge branch 'main' of https://github.com/bomctl/bomctl into gitlab-push
83535fd
@lmphil lmphil requested a review from a team as a code owner January 13, 2025 21:14
@lmphil lmphil self-assigned this Jan 13, 2025
@lmphil lmphil changed the title Gitlab push feat: add gitlab push to generic package registry Jan 13, 2025
@lmphil
refactor and ignore struct limit linter warning
7bc4656 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
jhoward-lm
jhoward-lm reviewed Jan 13, 2025
View reviewed changes
@lmphil
re-enable public struct limit linter warning
32b3eed 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil lmphil marked this pull request as draft January 13, 2025 23:25
jhoward-lm
jhoward-lm requested changes Jan 14, 2025
View reviewed changes
lmphil added 3 commits January 14, 2025 18:46
@lmphil
make all gitlab client structs and interfaces private except Client
308725f 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
add missing license header
4a3650f 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
disable import-shadowing revive rule specifically for section
8c19e3f 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil lmphil marked this pull request as ready for review January 15, 2025 02:56
jhoward-lm
jhoward-lm reviewed Jan 15, 2025
View reviewed changes
@lmphil
small non functional changes
8cec4f6 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
ashearin
ashearin requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ashearin ashearin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I noticed playing around with it.

Also if we keep the currently implemented expected form for this clients, we need to update docs to make it easily usable.

lmphil and others added 7 commits January 19, 2025 21:06
@lmphil
Merge branch 'main' of https://github.com/bomctl/bomctl into gitlab-push
df98189
@lmphil
support pushing spdx sboms to gitlab
8c1007a 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
add index check
40a2116 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
edit gitlab push url format and update doc
24fb580 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
fix linter error
563e45e 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@lmphil
refactor required fields check
5e363a5 
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
@ashearin
Merge branch 'main' into gitlab-push
7147b9b
@ashearin ashearin merged commit 82f98b7 into bomctl:main Jan 27, 2025
8 checks passed
@ashearin ashearin linked an issue Jan 27, 2025 that may be closed by this pull request
Push to generic package registry #265
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhoward-lm jhoward-lm jhoward-lm approved these changes

@ashearin ashearin ashearin approved these changes

Assignees

@ashearin ashearin

@lmphil lmphil

@jhoward-lm jhoward-lm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Push to generic package registry

3 participants

@lmphil @ashearin @jhoward-lm